Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom metadata field to alias #12502

Merged
merged 24 commits into from Sep 17, 2021
Merged

Add Custom metadata field to alias #12502

merged 24 commits into from Sep 17, 2021

Conversation

akshya96
Copy link
Contributor

@akshya96 akshya96 commented Sep 7, 2021

Add custom_metadata field to alias
Updated create, update, getbyaliasID and list
Policy templating changes to include custom_metadata

Testing :
curl --header X-Vault-Token:s.LoB6WLWugC7Y7qwKF1M49zO7 http://127.0.0.1:8200/v1/identity/entity-alias/id/12051e19-b256-0eed-35a0-879c2e308623
{"request_id":"459f2eec-5ded-da61-1237-da5c5d535712","lease_id":"","renewable":false,"lease_duration":0,"data":{"canonical_id":"da097a8e-224f-db02-9524-adfa2c48bb7d","creation_time":"2021-09-07T21:34:58.885245Z","custom_metadata":{"bar1":"1231","baz":"5c07d823-3810-48f6-a147-4c06b5219e84","foo1":"abc1"},"id":"12051e19-b256-0eed-35a0-879c2e308623","last_update_time":"2021-09-07T21:34:58.930261Z","merged_from_canonical_ids":null,"metadata":null,"mount_accessor":"auth_userpass_eadc45b0","mount_path":"auth/userpass/","mount_type":"userpass","name":"akshya2","namespace_id":"root"},"wrap_info":null,"warnings":null,"auth":null}

@vercel vercel bot temporarily deployed to Preview – vault September 7, 2021 21:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 7, 2021 21:40 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 7, 2021 23:39 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 7, 2021 23:39 Inactive
@akshya96 akshya96 changed the title Custom namespace alias Custom metadata alias Sep 7, 2021
@akshya96 akshya96 changed the title Custom metadata alias Add Custom metadata field to alias Sep 7, 2021
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

helper/identity/types.proto Outdated Show resolved Hide resolved
vault/identity_store_aliases.go Outdated Show resolved Hide resolved
vault/identity_store_aliases.go Outdated Show resolved Hide resolved
vault/identity_store_aliases.go Outdated Show resolved Hide resolved
vault/identity_store_aliases.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault September 14, 2021 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 14, 2021 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 14, 2021 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 14, 2021 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 14, 2021 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 14, 2021 21:10 Inactive
sdk/logical/identity.proto Outdated Show resolved Hide resolved
helper/identity/types.proto Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 15, 2021 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 15, 2021 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 15, 2021 21:58 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 15, 2021 21:58 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 16, 2021 17:05 Inactive
@akshya96 akshya96 merged commit d324066 into main Sep 17, 2021
@briankassouf briankassouf deleted the customNamespaceAlias branch September 30, 2021 00:19
@mladlow mladlow added this to the 1.9 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants