Allow signing self issued certs with a different public key algorithm. #12514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). vault – ./website🔍 Inspect: https://vercel.com/hashicorp/vault/GKgXygThCD3TM2issBtTeRkjP2FG [Deployment for a6998ef failed] vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/5ivJoDxDohAMLv8QJomHzYojzwW2 [Deployment for a6998ef canceled] |
sgmiller
force-pushed
the
pki-cross-sign2
branch
from
553456c
to
8f3ef44
Compare
briankassouf
approved these changes
Sep 13, 2021
sgmiller
added a commit
that referenced
this pull request
Sep 14, 2021
#12514) * WIP: Unset the certificate's SignatureAlgorithm to allown cross-signing of different key types * Allow signing self issued certs with a different public key algorithm * Remove cruft * Remove stale import * changelog * eliminate errwrap * Add a test to cover the lack of opt-in flag * Better comment Co-authored-by: catsby <clint@ctshryock.com>
sgmiller
added a commit
that referenced
this pull request
Sep 14, 2021
#12514) * WIP: Unset the certificate's SignatureAlgorithm to allown cross-signing of different key types * Allow signing self issued certs with a different public key algorithm * Remove cruft * Remove stale import * changelog * eliminate errwrap * Add a test to cover the lack of opt-in flag * Better comment Co-authored-by: catsby <clint@ctshryock.com>
sgmiller
added a commit
that referenced
this pull request
Sep 15, 2021
#12514) (#12549) * WIP: Unset the certificate's SignatureAlgorithm to allown cross-signing of different key types * Allow signing self issued certs with a different public key algorithm * Remove cruft * Remove stale import * changelog * eliminate errwrap * Add a test to cover the lack of opt-in flag * Better comment Co-authored-by: catsby <clint@ctshryock.com> Co-authored-by: catsby <clint@ctshryock.com>
sgmiller
added a commit
that referenced
this pull request
Sep 15, 2021
#12514) (#12548) * WIP: Unset the certificate's SignatureAlgorithm to allown cross-signing of different key types * Allow signing self issued certs with a different public key algorithm * Remove cruft * Remove stale import * changelog * eliminate errwrap * Add a test to cover the lack of opt-in flag * Better comment Co-authored-by: catsby <clint@ctshryock.com> Co-authored-by: catsby <clint@ctshryock.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this by setting the signing algorithm of the template to the signing
key's algorithm iff they differ and "allow_different_signature_algorithm" is
true.
This is branched from #8157, but made more explicit.
Addresses hashicorp/consul#8576