Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkcs7 parsing in some cases #12519

Merged
merged 3 commits into from Sep 10, 2021
Merged

Fix pkcs7 parsing in some cases #12519

merged 3 commits into from Sep 10, 2021

Commits on Sep 8, 2021

  1. Fix pkcs7 parsing in some cases 

    brings in mozilla-services/pkcs7#61 from upstream

In some cases but not all, aws includes a certificate in the pkcs7 response,
and currently vault fails to parse those certificates:
```
URL: PUT https://vault.example.com/v1/auth/aws/login
Code: 500. Errors
* failed to parse the BER encoded PKCS#7 signature: ber2der: Invalid BER format
```

This fixes logins on those instances.  Note we could not readily ascertain why
some instances have those certificates and others don't.
    @maths22
    maths22 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    d527f44 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @maths22
    maths22 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    4308d01 View commit details
    Browse the repository at this point in the history

  3. Correct missed line

    @maths22
    maths22 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    98c7b8e View commit details
    Browse the repository at this point in the history