Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/ PKI UI Redesign #12541

Merged
merged 41 commits into from Oct 4, 2021
Merged

UI/ PKI UI Redesign #12541

merged 41 commits into from Oct 4, 2021

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Sep 13, 2021

Utilizes node-forge to parse the PKI certificate's metadata and display issueDate, expiryDate and commonName:

Previous behavior:

Screen Shot 2021-09-20 at 9 10 38 AM

Screen Shot 2021-09-20 at 9 10 48 AM

Current behavior:

Screen Shot 2021-09-20 at 9 15 39 AM

Screen Shot 2021-09-20 at 9 15 45 AM

@light1021
Copy link

Thanks for the suggestion, @light1021! We definitely see this is a useful addition and I believe it's going to be addressed in another PR. I'll check-in with our design team to make sure this is the case.

Any way, thanks for your work~

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! A couple small updates requested

ui/app/adapters/pki-ca-certificate.js Outdated Show resolved Hide resolved
ui/app/helpers/parse-pki-cert.js Outdated Show resolved Hide resolved
ui/app/models/pki-ca-certificate.js Outdated Show resolved Hide resolved
ui/app/models/pki-certificate.js Outdated Show resolved Hide resolved
ui/app/templates/components/config-pki-ca.hbs Show resolved Hide resolved
ui/lib/core/addon/helpers/date-format.js Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault September 27, 2021 20:09 Inactive
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mladlow
Copy link
Contributor

mladlow commented Oct 6, 2021

@hellobontempo will there need to be documentation updates for this change?

@hellobontempo
Copy link
Contributor Author

@hellobontempo will there need to be documentation updates for this change?

@mladlow - Thanks for checking! Nope - I don't think so. The only relevant docs I see are Build Your Own Certificate Authority (CA) and I don't seen any screenshots that display the certificate data. This PR is just visual and adds some of the cert metadata to the certificate view page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants