Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-3519] Return no_default_policy on token role read #12565

Merged
merged 6 commits into from Sep 21, 2021
Merged

[VAULT-3519] Return no_default_policy on token role read #12565

merged 6 commits into from Sep 21, 2021

Conversation

pmmukh
Copy link
Contributor

@pmmukh pmmukh commented Sep 15, 2021 •
edited

  • Returns the token_no_default_policy config on token role read
  • Updates tests to check the same

Fixes #12225

@pmmukh pmmukh requested review from ncabatoff and a team September 15, 2021 22:20
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 15, 2021 22:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 15, 2021 22:22 Inactive
vishalnayak
vishalnayak reviewed Sep 20, 2021
View reviewed changes
vault/token_store.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 20, 2021 21:09 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 20, 2021 21:09 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 20, 2021 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 20, 2021 21:55 Inactive
vishalnayak
vishalnayak approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional] You might want to update the sample response on the API docs for the read.

@pmmukh
Copy link
Contributor Author

pmmukh commented Sep 21, 2021 •
edited

[Optional] You might want to update the sample response on the API docs for the read.

Ah yeah will do that, thanks for the catch!

@pmmukh pmmukh changed the title [VAULT-3519] Return no_default_policy on token role read if set [VAULT-3519] Return no_default_policy on token role read Sep 21, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 21, 2021 16:30 Inactive
@pmmukh pmmukh merged commit cf45b2b into main Sep 21, 2021
@pmmukh pmmukh deleted the vault-3519-update-token-role-read branch September 21, 2021 16:53
@tristanmorgan tristanmorgan mentioned this pull request Oct 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@ncabatoff ncabatoff Awaiting requested review from ncabatoff

@taoism4504 taoism4504 Awaiting requested review from taoism4504

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Token Auth] Roles not returning token_no_default_policy
2 participants
@pmmukh @vishalnayak