Added namespace search to client count #12577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnav28
commented
Sep 17, 2021
•
arnav28
commented
- Used existing search select component for namespace search
- Added option to export all namespaces data
- Show root in Top 10 namespaces list
- Used existing search select component for namespace search
- generate namespaces data in csv format - Show root in top 10 namespaces - Changed active direct tokens to non-entity tokens
Monkeychip
reviewed
Sep 22, 2021
|
|
||
| // Construct the namespace model for the bar chart component | ||
| get barChartDataset() { | ||
| if (!this.args.model.activity || !this.args.model.activity.byNamespace) { |
There was a problem hiding this comment.
nice call on adding these checks first
Monkeychip
reviewed
Sep 22, 2021
Monkeychip
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.