Update Azure secrets engine to use MS Graph #12629
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcman312
commented
Sep 24, 2021
| @@ -107,7 +107,7 @@ require ( | |||
| github.com/hashicorp/vault-plugin-mock v0.16.1 | |||
| github.com/hashicorp/vault-plugin-secrets-ad v0.10.0 | |||
| github.com/hashicorp/vault-plugin-secrets-alicloud v0.9.0 | |||
| github.com/hashicorp/vault-plugin-secrets-azure v0.10.0 | |||
| github.com/hashicorp/vault-plugin-secrets-azure v0.6.3-0.20210924190759-58a034528e35 | |||
There was a problem hiding this comment.
I don't know why this is going to 0.6.3, but the commit hash is correct.
There was a problem hiding this comment.
I think the repo needs to be tagged to v0.11.0 and we add that here. Thoughts?
There was a problem hiding this comment.
I was going to wait on tagging the repo since I'm going to be working on root credential rotation next. I can tag it now though if you prefer?
There was a problem hiding this comment.
Yeah good point, let's wait on tagging.
pcman312
requested review from
calvn,
vinay-gopalan,
jasonodonnell,
fairclothjm and
austingebauer
pcman312
added
dependencies
jasonodonnell
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in hashicorp/vault-plugin-secrets-azure#67 to start migrating away from the deprecated Azure Active Directory API to the Microsoft Graph API.
Also adds docs for the new feature flag:
use_microsoft_graph_apiand a warning that current users should migrate their configurations before the AAD API is removed by Microsoft.