Add missing read unlock calls in transit backend code #12651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* oss part of control groups upgrade * changelog and docs * formatting * formatting
…pan. (#11760) * wip * wip * Finish implementing advice handling and word wrapping * Properly word wrap messages and warnings * Remove debugging * Remove debugging * Remove unnecessary test * unit test bug * go vendor
* Update secret backend partial to components * Added jsdoc to components
* replace last two partials * cleanup * modify test to cover new component * only on ca role run new function * help with inconsistent failure on enterprise test * small changes to help with flaky test locally * add js docs
…cense inspect PR in ent. (#11783)
* moved client content from cloud to vault * Empty commit trigger Co-authored-by: Michele <mdeggies@gmail.com>
* Fix the third dumb thing in this file * ...
* chore: updates alert banner data * Update website/data/alert-banner.js
… to try to grab the readlock when we're servicing a request (#11793)
Updated content to notify the users that the Special and Control characters will be escaped as per the JSON specification.
…11755) Fixed the issue with the URL link for the Password Policy Syntax.
* Update serializer for license and example response * Wrap mirage license/status in data
* Upgrade packagespec to 0.2.6 * Remove darwin/arm64 from building
* Udate to Go 1.16.5 * Add CL * Update packages-oss.yml * Update go_test.yml
- This defeats CircleCI's "no output timeout"
* Add username_template to influxdb * go fmt * goimport for influxdb.go
…er. (#11122) * Acquire a per-lock lease to make renew and revoke atomic wrt each other. This means we don't have to hold pendingLock during I/O. * Attempted fix for deadlock in token revocation. * Comment fix. * Fix error checking in loadEntry. * Add benchmark * Add a few additional locking locations * Improve benchmark slightly * Update vault/expiration.go Co-authored-by: swayne275 <swayne275@gmail.com> * Update vault/expiration.go Co-authored-by: swayne275 <swayne275@gmail.com> * Add a lease lock into tidy Co-authored-by: Scott Miller <smiller@hashicorp.com> Co-authored-by: Brian Kassouf <bkassouf@hashicorp.com> Co-authored-by: Brian Kassouf <briankassouf@users.noreply.github.com> Co-authored-by: swayne275 <swayne275@gmail.com>
* fix m.coreStateLock deadlock for API handler code * improve lock comment
* initial refactoring of unseal step in run * remove waitgroup * remove waitgroup * backup work * backup * backup * completely modularize run and move into diagnose * add diagnose errors for incorrect number of unseal keys * comment tests back in * backup * first subspan * finished subspanning but running into error with timeouts * remove runtime checks * merge main branch * meeting updates * remove telemetry block * roy comment * subspans for seal finalization and wrapping diagnose latency checks * backup while I fix something else * fix storage latency test errors * runtime checks * diagnose with timeout on seal
* plugin/snowflake: update gosnowflake to v1.6.1 (#12378) * plugin/snowflake: update gosnowflake to v1.6.1 * changelog * go mod tidy * go mod tidy
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
#12361) * creds/aws: import pkcs7 verification package * Add DSA support * changelog * Add DSA to correct verify function * Remove unneeded tests * Fix backend test * Update builtin/credential/aws/pkcs7/README.md Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com> * Update builtin/credential/aws/path_login.go Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com> Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com> Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
* packagespec upgrade -version 0.2.8 * make packages
* Enforce Minimum cache size for transit backend * enfore minimum cache size and log a warning during backend construction * Update documentation for transit backend cache configuration * Added changelog * Addressed review feedback and added unit test * Modify code in pathCacheConfigWrite to make use of the updated cache size * Updated code to refresh cache size on transit backend without restart * Update code to acquire read and write locks appropriately
… in pathCacheCconfigRead
divyapola5
requested review from
victorr,
cipherboy,
sgmiller and
rculpepper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup for #12418 and in summary includes the following changes:
1 - Add missing read unlock calls for cacheSizeChanged variable
2 - Invoke initCache in pathCacheConfigRead routine if needed