Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing read unlock calls in transit backend code #12652

Merged
merged 4 commits into from Sep 28, 2021

Conversation

divyapola5
Copy link
Contributor

This PR is a followup for #12418 and in summary includes the following changes:
1 - Add missing read unlock calls for cacheSizeChanged variable
2 - Invoke initCache in pathCacheConfigRead routine if needed

@vercel vercel bot temporarily deployed to Preview – vault-storybook September 27, 2021 21:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 27, 2021 21:59 Inactive
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but please verify the changelog entry with someone (maybe Scott?)

changelog/12652.txt Outdated Show resolved Hide resolved
builtin/logical/transit/backend.go Show resolved Hide resolved
changelog/12652.txt Outdated Show resolved Hide resolved
@ncabatoff ncabatoff added this to the 1.8.3 milestone Sep 28, 2021
@vercel vercel bot temporarily deployed to Preview – vault September 28, 2021 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 28, 2021 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 28, 2021 16:23 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 28, 2021 16:23 Inactive
@divyapola5 divyapola5 merged commit 558ed17 into main Sep 28, 2021
@divyapola5 divyapola5 deleted the transitCacheConfig branch September 28, 2021 16:59
divyapola5 added a commit that referenced this pull request Sep 28, 2021
* Add missing read unlock calls in transit backend code

* Correct formatting in changelog entry
sgmiller pushed a commit that referenced this pull request Sep 28, 2021
* Add missing read unlock calls in transit backend code

* Correct formatting in changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants