Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to parameterize unauthenticated paths #12668

Merged
merged 25 commits into from Oct 13, 2021
Merged

Add support to parameterize unauthenticated paths #12668

merged 25 commits into from Oct 13, 2021

Commits on Sep 29, 2021

  1. store unauthenticated path wildcards in map

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    49a6c4b View commit details
    Browse the repository at this point in the history

  2. working unauthenticated paths with basic unit tests

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f46cacc View commit details
    Browse the repository at this point in the history

  3. refactor wildcard logic

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    c287044 View commit details
    Browse the repository at this point in the history

  4. add parseUnauthenticatedPaths unit tests

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    e8ef63d View commit details
    Browse the repository at this point in the history

  5. use parseUnauthenticatedPaths when reloading backend

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a3b77aa View commit details
    Browse the repository at this point in the history

  6. add more wildcard test cases

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    9eb4fb4 View commit details
    Browse the repository at this point in the history

  7. update special paths doc; add changelog

    @fairclothjm
    fairclothjm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    cf3a93d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. remove buggy prefix check; add test cases

    @fairclothjm
    fairclothjm committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    329f214 View commit details
    Browse the repository at this point in the history

  2. prevent false positives for prefix matches 

    If we ever encounter a mismatched segment, break and set a flag to
prevent false positives for prefix matches.

If it is a match we need to do a prefix check. But we should not return
unless HasPrefix also evaluates to true. Otherwise we should let the for
loop continue to check other possibilities and only return false once
all wildcard paths have been evaluated.
    @fairclothjm
    fairclothjm committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    3bbe5b0 View commit details
    Browse the repository at this point in the history

  3. refactor switch and add more test cases

    @fairclothjm
    fairclothjm committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    dbad5eb View commit details
    Browse the repository at this point in the history

  4. remove comment leftover from debug session

    @fairclothjm
    fairclothjm committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    ae8b73a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. add more wildcard path validation and test cases

    @fairclothjm
    fairclothjm committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    4ba8baa View commit details
    Browse the repository at this point in the history

  2. update changelong; feature -> improvement

    @fairclothjm
    fairclothjm committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    bbb0156 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. simplify wildcard segment matching logic

    @fairclothjm
    fairclothjm committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    ef652a6 View commit details
    Browse the repository at this point in the history

  2. refactor wildcard matching into func

    @fairclothjm
    fairclothjm committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    1d18b42 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into unauth-paths-wildcard

    @fairclothjm
    fairclothjm committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    5ff9e51 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. fix glob matching, add more wildcard validation, refactor

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    c2352c0 View commit details
    Browse the repository at this point in the history

  2. refactor common wildcard errors to func

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3d7cfd7 View commit details
    Browse the repository at this point in the history

  3. move doc comment to logical.Paths

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    8ffb279 View commit details
    Browse the repository at this point in the history

  4. optimize wildcard paths storage with pre-split slices

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    b9c7d33 View commit details
    Browse the repository at this point in the history

  5. fix comment typo

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d8070f0 View commit details
    Browse the repository at this point in the history

  6. fix test case after changing wildcard paths storage type

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    b824939 View commit details
    Browse the repository at this point in the history

  7. move prefix check to parseUnauthenticatedPaths

    @fairclothjm
    fairclothjm committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    44186ba View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. tweak regex, remove unneeded array copy, refactor

    @fairclothjm
    fairclothjm committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    42d86dd View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. add test case around wildcard and glob matching

    @fairclothjm
    fairclothjm committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    e87339c View commit details
    Browse the repository at this point in the history