Fix a Deadlock on HA leadership transfer #12691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was actively forwarding a request fixes GH #12601
ncabatoff
approved these changes
Sep 30, 2021
hghaf099
added a commit
that referenced
this pull request
Oct 4, 2021
* Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request fixes GH #12601 * adding the changelog
hghaf099
added a commit
that referenced
this pull request
Oct 4, 2021
* Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request fixes GH #12601 * adding the changelog
hghaf099
added a commit
that referenced
this pull request
Oct 4, 2021
* Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request fixes GH #12601 * adding the changelog
hghaf099
added a commit
that referenced
this pull request
Oct 4, 2021
hghaf099
added a commit
that referenced
this pull request
Oct 4, 2021
hghaf099
added a commit
that referenced
this pull request
Oct 4, 2021
|
@hghaf099 and @ncabatoff although this fix seems only to apply to perf standbys which are not included in OSS vault, can you please clarify if this fix applies to the OSS users too? It's unclear if the code path that leads to the deadlock applies to OSS. Thanks. |
|
Yes, it applies to OSS. The deadlock involves access to a mutex-protected field named perfStandby, but the field is accessed even by regular standbys. |
|
Thank you very much! |
tionebsalocin
added a commit
to criteo-forks/vault
that referenced
this pull request
Mar 14, 2022
…2691) * Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request fixes GH hashicorp#12601 * adding the changelog
tionebsalocin
pushed a commit
to criteo-forks/vault
that referenced
this pull request
Mar 15, 2022
…#12721) * Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request fixes GH hashicorp#12601 * adding the changelog
tionebsalocin
pushed a commit
to criteo-forks/vault
that referenced
this pull request
Mar 15, 2022
…#12722) * Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request fixes GH hashicorp#12601 * adding the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a Deadlock on HA leadership transfer when standby was actively forwarding a request
fixes GH #12601