CLI request when namespace is in argument and part of the path #12720
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… argument and part of the path fixes #12675
ccapurso
requested changes
Oct 5, 2021
There was a problem hiding this comment.
I left a couple comments that would improve the readability and error handling. It looks good at a high level but we should add some tests to validate that the bug no longer exists. Some test scenarios might provide a little extra context for me to analyze the logic a little further as well.
|
Yes, I am creating some tests, however, the tests are going to be in the enterprise side, as namespaces are required to fully examine the change. |
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
…corp#12720) * CLI makes request to incorrect URL when namespace is both provided as argument and part of the path fixes hashicorp#12675 * adding change log * removing a switch and addressing a possibility of out of bound index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI makes request to incorrect URL when namespace is both provided as argument and part of the path
fixes #12675