Diagnose partial/missing telemetry configuration #12802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sgmiller
requested review from
HridoyRoy and
briankassouf
and removed request for
a team
HridoyRoy
reviewed
Oct 20, 2021
| } else { | ||
| t := config.Telemetry | ||
| // If any Circonus setting is present but we're missing the basic fields... | ||
| if coalesce(t.CirconusAPIURL, t.CirconusAPIToken, t.CirconusCheckID, t.CirconusCheckTags, t.CirconusCheckSearchTag, |
There was a problem hiding this comment.
nit: there are a lot of fields in the if statement here. Would it be helpful to add the fields that signify a present Circonus configuration to a struct?
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* Diagnose partial/missing telemetry configuration * changelog * fixup * not sure which component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.