Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/remove empty rows from DB config pages #12819

Merged
merged 7 commits into from Oct 14, 2021
Merged

UI/remove empty rows from DB config pages #12819

merged 7 commits into from Oct 14, 2021

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Oct 13, 2021 •
edited

Previously, empty config rows were still displaying

Screen Shot 2021-10-13 at 11 56 58 AM

Added helper so alwaysRender is only true if the rows have a value

Screen Shot 2021-10-13 at 3 27 51 PM

@hellobontempo hellobontempo added this to the 1.9 milestone Oct 13, 2021
@vercel vercel bot temporarily deployed to Preview – vault October 13, 2021 19:01 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 13, 2021 19:01 Inactive
Monkeychip
Monkeychip approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling!

@vercel vercel bot temporarily deployed to Preview – vault October 13, 2021 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 13, 2021 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 13, 2021 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 13, 2021 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 14, 2021 19:20 Inactive
@hellobontempo hellobontempo merged commit 28ecc17 into main Oct 14, 2021
@hellobontempo hellobontempo deleted the ui/db-cleanup branch October 14, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellobontempo @Monkeychip