Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity alias deletion #12834

Merged
merged 4 commits into from Oct 19, 2021
Merged

Fix entity alias deletion #12834

merged 4 commits into from Oct 19, 2021

Conversation

vishalnayak
Copy link
Member

No description provided.

Copy link
Contributor

@pmmukh pmmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple questions, but lgtm!

@vercel vercel bot temporarily deployed to Preview – vault-storybook October 19, 2021 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 19, 2021 14:35 Inactive
Copy link
Contributor

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, don't forget the CL!

@vercel vercel bot temporarily deployed to Preview – vault October 19, 2021 18:41 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 19, 2021 18:41 Inactive
@vishalnayak vishalnayak merged commit bcdfd40 into main Oct 19, 2021
@vishalnayak vishalnayak deleted the fix-alias-deletion branch October 19, 2021 19:05
vishalnayak added a commit that referenced this pull request Oct 19, 2021
* Fix entity alias deletion

* Fix tests

* Add CL
vishalnayak added a commit that referenced this pull request Oct 19, 2021
* Fix entity alias deletion

* Fix tests

* Add CL
vishalnayak added a commit that referenced this pull request Oct 20, 2021
* Fix entity alias deletion (#12834)

* Fix entity alias deletion

* Fix tests

* Add CL

* Remove 1.9 changes
vishalnayak added a commit that referenced this pull request Oct 20, 2021
* Fix entity alias deletion (#12834)

* Fix entity alias deletion

* Fix tests

* Add CL

* Remove 1.9 changes
vishalnayak added a commit that referenced this pull request Oct 20, 2021
* Fix entity alias deletion

* Fix tests

* Add CL
vishalnayak added a commit that referenced this pull request Oct 20, 2021
* Fix entity alias deletion (#12834)

* Fix entity alias deletion

* Fix tests

* Add CL

* Fix go.sum

* Remove 1.9 changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants