Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT 2844: remove legacy lease revocation strategy #12888

Merged
merged 5 commits into from Oct 22, 2021
Merged

VAULT 2844: remove legacy lease revocation strategy #12888

merged 5 commits into from Oct 22, 2021

Conversation

swayne275
Copy link
Contributor

@swayne275 swayne275 commented Oct 20, 2021 •
edited

No description provided.

@swayne275 swayne275 added this to the 1.9 milestone Oct 20, 2021
@swayne275 swayne275 requested review from briankassouf, ncabatoff and a team October 20, 2021 18:45
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 20, 2021 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 20, 2021 18:50 Inactive
vishalnayak
vishalnayak reviewed Oct 20, 2021
View reviewed changes
changelog/12888.txt Outdated Show resolved Hide resolved
@ncabatoff
Copy link
Contributor

Can VAULT_16_REVOKE_PERMITPOOL be removed at the same time? Doesn't do anything anymore right?

@swayne275
Copy link
Contributor Author

@ncabatoff i think that's reasonable. okay to do in a separate PR, or do you think it makes more sense as a combo?

@ncabatoff
Copy link
Contributor

@ncabatoff i think that's reasonable. okay to do in a separate PR, or do you think it makes more sense as a combo?

I don't see any reason to keep it around when it doesn't do anything, and it's not like it's going to make the PR much bigger to include that. So I'd prefer to see both tackled here.

@vercel vercel bot temporarily deployed to Preview – vault-storybook October 22, 2021 15:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 22, 2021 15:26 Inactive
@swayne275
Copy link
Contributor Author

@ncabatoff updated!

@vercel vercel bot temporarily deployed to Preview – vault-storybook October 22, 2021 15:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 22, 2021 15:28 Inactive
@swayne275 swayne275 merged commit 6a0c970 into main Oct 22, 2021
@swayne275 swayne275 deleted the vault-2844_remove-legacy-revocation-strategy branch October 22, 2021 23:37
qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
@swayne275
VAULT 2844: remove legacy lease revocation strategy (hashicorp#12888)
98236e9 
* remove legacy lease revocation strategy

* add deprecation change log note

* remove VAULT_16_REVOKE_PERMITPOOL

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@ncabatoff ncabatoff ncabatoff approved these changes

@briankassouf briankassouf Awaiting requested review from briankassouf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swayne275 @ncabatoff @vishalnayak