UI Conditionally Copy Tooltips #12890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hashishaw
approved these changes
Oct 20, 2021
| @@ -71,6 +71,29 @@ module('Integration | Component | InfoTableRow', function(hooks) { | |||
| assert.equal(tooltip, 'Tooltip text!', 'renders tooltip text'); | |||
| }); | |||
|
|
|||
| test('it should copy tooltip', async function(assert) { | |||
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* adds conditional tooltip copying to InfoTableRow component * adds changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was requested that the Last Vault rotation timestamp value for static database roles which is presented in a tooltip could be clicked to copy to the clipboard.
What was changed
How to test
Since the ToolTip component yields components for the trigger and content it seemed best to defer responsibility of copying to the outer component. I considered creating a component to wrap the content component from ember basic dropdown which could then accept an argument such as
copyTextand yield that but ultimately decided against it. I'm happy to move in that direction if there is support for it.