Vertical resize on .cm-s-hashi.CodeMirror

[djvs]

Allows user to resize JSON editor to be more or less fullscreen. Essential UI fix IMO.

[hashicorp-cla]

All committers have signed the CLA.

[djvs]

May be more than one .cm-whatever.CodeMirror that this applies for, I don't see one on my end though. Well - in the SCSS, but not in the UI.

[Monkeychip]

@djvs can you provide a screenshot or gif of the change on the UI? I'm trying to reproduce where your scss change is occurring. Thank you!

[djvs]

Note the bottom right corner (and larger view height)

[djvs]

More-or-less equivalent user style I applied locally via browser extension is just .CodeMirror{ resize: 'vertical'; }. I can make this change if you guys want it globally, I'm not quite sure what different contexts you have CodeMirror spun up in.

[hsimon-hashicorp]

Note the bottom right corner (and larger view height)

I don't have much to add here except a very personal note that I really love the example you used here for the text entry. :)

[Monkeychip]

@djvs thank you for the screenshot. I'm a little confused because in order for me to apply this styling on the Codemirror component, I have to add the resize: vertical to line 53 here, instead of where you have it in ui/app/styles/components/console-ui-panel.scss (which is for the drop-down CLI editor available on the UI - see screenshot below).

I'll go ahead and check with design on this. But if you can, go ahead and make the styling change to the file I indicated and test that this still solves your issue.

[djvs]

Whoops - updated.

[Monkeychip]

@djvs thank you for the update. Also, sorry one more change. The changelog file, here is an example of how to do this. This process recently changed, and it's a reminder for me to make sure our Readme is up to date. In the example, you would also put "improvement". Essentially, create a new file with the name of the PR number (e.g. 12906.txt) and put in the changelog file (this is outside of the UI folder).

I got the thumbs up from design. Once the changelog is update, I can approve and merge.

[Monkeychip]

Thank you!

[djvs]

By the way this resize grabber is almost invisible on the latest version -

[Monkeychip]

@djvs looking into this a little. It appears this is the standard resize icon for codemirror. I suspect it's a little hard to see because of the black background. Is this the size you are seeing as well? I have been playing around with this and don't see a way to make it any larger.