Extend kv metadata to get, put, and patch #12907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
changed the title
hghaf099
reviewed
Oct 26, 2021
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* go get vault-plugin-secrets-kv@extend-kv-metadata-to-get-and-put * test for custom_metadata in kv get, put, patch command output * remove flagFormat-specific check from TestKVMetadataGetCommand * rewrite custom metadata changelog entry * go get vault-plugin-secrets-kv@master * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides test changes to verify CLI output for the extension of KVv2's key metadata field
custom_metadatato theCreateOperation,ReadOperation, andPatchOperationresponses for the/<mount>/data/:pathendpoint. The affected CLI commands arevault kv get secret/foo,vault kv put secret/foo,vault kv patch secret/foo.Related Issues/Pull Requests