Info table row typography #12908
Merged
Info table row typography #12908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a possible flaky acceptance test is failing. tests/acceptance/settings/mount-secret-backend-test.js It passes locally the majority of the time but I have been able to get it to fail a couple of times. I'll see if I can isolate the issue and refactor it. |
|
In the test a series of console commands are run, the last of which creates a token which is then accessed with |
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* updates info table row value font * adds changelog * updates tests * attempts to fix flaky mount-secret-backend acceptance test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change of font used for the value field in the info table row component by using a span instead of code tag.