Use mutex in OIDC configuration handlers #12932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
requested review from
calvn,
jasonodonnell,
fairclothjm and
vinay-gopalan
jasonodonnell
approved these changes
Oct 26, 2021
vinay-gopalan
approved these changes
Oct 26, 2021
fairclothjm
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds use of the oidcLock in configuration handlers for Vault OIDC provider. The purpose of using this lock is to avoid race conditions where concurrent configuration changes could leave relationships between resources in an inconsistent state. For example, we implement checks to ensure that named resource references (e.g., client->assignment, provider->scopes_supported) exist. Using a mutex for writes ensures that the reference checks won't race.
The mutex is not used to protect unsafe memory in this case. All in-memory data structures (go-memdb, go-cache) internally use a mutex or provide safe concurrent access through other means.