go-kms-wrapping update for Azure Key Vault's Managed HSM offering [backport 1.7.x] #12957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
requested review from
victorr,
sgmiller,
stevendpclark,
rculpepper and
divyapola5
Co-authored-by: Rachel Culpepper <84159930+rculpepper@users.noreply.github.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This introduces the "resource" config parameter and the AZURE_AD_RESOURCE environment variable from the updated go-kms-wrapping dependency. Co-authored-by: Rachel Culpepper <84159930+rculpepper@users.noreply.github.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Includes changes from @stevendpclark. Co-authored-by: Rachel Culpepper <84159930+rculpepper@users.noreply.github.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
go-kms-wrapping-update-1.7.x
branch
from
436056b
to
a2b9cfa
Compare
sgmiller
approved these changes
Oct 29, 2021
|
Thanks Scott! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12934 and #12952 to 1.7.x
The recently released update of
go-kms-wrapping@v0.6.8includes support for Azure KeyVault's Managed HSM offering. While the non-HSM-backed KeyVault offering was initially supported, support for the Managed HSM offering was broken because required customization wasn't exposed from the underlying library (namely,environment.KeyVaultDNSSuffix).Respecting Azure SDK's
AZURE_AD_RESOURCEvariable (and mirroring it as aresourcefield in the KeyVault seal config struct) allows us to use this type of KeyVault.Update to
go.mod/go.sumwas created viago get -u github.com/hashicorp/go-kms-wrapping@v0.6.8followed by ago mod tidyand ago mod vendor(for 1.7.x).Note, per discussion between myself, Jeff Mitchell, Scott Miller, and Rachel Culpepper, we've decided updating from v0.5.16 to v0.6.8 (in g-k-w) to be fairly safe.
I've tested this locally with the KeyVault HSM and it functions as expected with the updated g-k-w.