remove nil response to 404 translation for PatchOperation #13167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
approved these changes
Nov 23, 2021
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
…13167) * remove nil response to 404 translation for PatchOperation * go get vault-plugin-secrets-kv@master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12687 included translation of a nil
logical.Responsefor aPatchOperationrequest to a 404. After further review, there are cases whereCreateOperationandUpdateOperationhandlers return a nil response resulting in a 204. It is prudent to remain consistent for operations against the same endpoint. With that said, it makes sense to remove this global translation. Backends will need to call thelogical.RespondWithStatusCodewithhttp.StatusNotFoundto embed a404 Not Foundas thehttp_status_codefor thelogical.Response.The
TestHandler_Patch_NotFoundtest has been removed as that was written specifically to ensure that the global nil -> 404 translation occurred.PR #56 for
vault-plugin-secrets-kvremoves the implied404 Not Foundresponse by returning a nillogical.Responsein favor of an explicit response.