Form field component ttl picker not initially enabling #13177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
approved these changes
Nov 17, 2021
|
Thanks @Monkeychip. After looking into your comment on Slack I noticed that the toggle was enabled for the default |
zofskeez
added a commit
that referenced
this pull request
Nov 18, 2021
* fixes issue with ttl picker not initially enabling in form field component * adds changelog entry * updates test * updates initial ttl toggle state for default 0s value
zofskeez
added a commit
that referenced
this pull request
Nov 19, 2021
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* fixes issue with ttl picker not initially enabling in form field component * adds changelog entry * updates test * updates initial ttl toggle state for default 0s value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TtlPicker2 instance in the FormField component was missing the
initialEnabledargument which was causing the toggle to be unchecked and the value to be hidden initially. Toggling the input would reveal the set value.After adding the argument the initial state is properly reflected.