Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client count docs #13197

Closed
wants to merge 4 commits into from
Closed

Update client count docs #13197

wants to merge 4 commits into from

Conversation

jweissig
Copy link
Contributor

Synced changes.

Synced changes.
@jweissig jweissig requested review from taoism4504 and removed request for taoism4504 November 18, 2021 02:23

If you chose to use the [Token Auth Method](/docs/auth/token) without an identity to avoid driving up client count, always assign each token to a role and entity alias. HashiCorp recommends creating a [Token Role](/api-docs/auth/token#create-update-token-role) first, with allowable entity aliases and issuing your token with the appropriate [role and entity alias name](/api-docs/auth/token#create-token). This is the name that will uniquely identify the client, no matter how many tokens are issued. See more on entity alias below.
If you choose to use the [Token Auth Method](https://www.vaultproject.io/docs/auth/token) without an identity, a non-entity token, to avoid driving up client count, always assign each token to a role and entity alias. HashiCorp recommends creating a [Token Role](https://www.vaultproject.io/api-docs/auth/token#create-update-token-role) first, with allowable entity aliases and issuing your token with the appropriate [role and entity alias name](https://www.vaultproject.io/api-docs/auth/token#create-token). This is the name that will uniquely identify the client, no matter how many tokens are issued. Without this each token will be counted as a client instead. For further information, please refer to the changes reflected in the [1.9 release notes](https://www.vaultproject.io/docs/release-notes/1.9.0) or check out our [learn guide](https://learn.hashicorp.com/collections/vault/new-release).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per engineering's markdown guidelines, please use absolute paths starting from the root when linking on the same site.
https://vaultproject.io/docs/auth/token -> /docs/auth/token
https://vaultproject.io/api-docs/auth/token/#create-update-token-role -> /api-docs/auth/token/#create-update-token-role

Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions, but otherwise LGTM.

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
@aphorise
Copy link
Contributor

Closing in favour of: #16795

@aphorise aphorise closed this Aug 19, 2022
HridoyRoy added a commit that referenced this pull request Aug 24, 2022
* Docs: Client Count Concept clarity. Closes #12849

* Update website/content/docs/concepts/client-count/index.mdx

* Docs: Client Count Concept clarity merged #13197 too.

* Update website/content/docs/concepts/client-count/index.mdx

Co-authored-by: Max Bowsher <maxbowsher@gmail.com>

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
Co-authored-by: Hridoy Roy <hridoyroy@berkeley.edu>
Co-authored-by: Max Bowsher <maxbowsher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants