Fix regression in returning empty value for approle cidrlist. #13235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
reviewed
Nov 22, 2021
| if len(in) == 0 { | ||
| // Don't change unnecessarily, if it was empty list leave as empty list | ||
| // instead of making it nil. | ||
| return in |
There was a problem hiding this comment.
Wonder if we should have a test for this?
There was a problem hiding this comment.
Feels like one of those things where if we were to apply a consistent standard, we'd need to add thousands more tests.
There was a problem hiding this comment.
Yeah, I figured as much. All good.
benashz
approved these changes
Nov 23, 2021
ncabatoff
added a commit
that referenced
this pull request
Nov 23, 2021
ncabatoff
added a commit
that referenced
this pull request
Nov 23, 2021
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13226