Add validation for nonce size when we aren't in convergent encryption mode within transit backend #13690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mode within transit backend
sgmiller
approved these changes
Jan 18, 2022
joatmon08
pushed a commit
that referenced
this pull request
Jan 25, 2022
… mode within transit backend (#13690) * Add validation for nonce size when we aren't in convergent encryption mode within transit backend * Add changelog entry
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
… mode within transit backend (hashicorp#13690) * Add validation for nonce size when we aren't in convergent encryption mode within transit backend * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend will panic when provided with a nonce value that is an invalid size when the key type is one of AES256_GCM96, AES128_GCM96, ChaCha20_Poly1305 within transit when the key does not have convergent encryption enabled.
Within sdk/helper/keysutil/policy.go func SymmetricEncryptRaw we are missing a test for the nonce size when we aren't in convergent encryption mode. We only check the nonce size is 0 to generate a value.
See VAULT-4533 for more details.