UI/fix db role ttl display #14224
Merged
UI/fix db role ttl display #14224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
reviewed
Feb 23, 2022
| @@ -63,6 +63,14 @@ | |||
| @label={{capitalize (or attr.options.label (humanize (dasherize attr.name)))}} | |||
| @value={{stringify (get @model attr.name)}} | |||
| /> | |||
| {{else if (eq attr.options.editType "ttl")}} | |||
There was a problem hiding this comment.
just checking that the editType here doesn't need to be default_ttl?
There was a problem hiding this comment.
Nope, the attr.name is default_ttl, but here I'm checking if editType (as set in the options on the model) is ttl, as it is for max_ttl as well, so that we can format it correctly 👍
Monkeychip
approved these changes
Feb 23, 2022
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a UI issue where the TTL looked like it never changed from 1h (the default) when really the adapter was not parsing the correct value from the API, which is
default_ttl.