Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Requests to resultant-acl Endpoint When Unauthenticated #17139

Merged
merged 3 commits into from Sep 15, 2022

Conversation

zofskeez
Copy link
Contributor

In PR #12713 the /sys/internal/ui/resultant-acl endpoint was made to be authenticated. As mentioned in issue #14097 the UI was continuing to make requests to this endpoint when unauthenticated so that has been updated as well as an update to the api doc.

@zofskeez zofskeez added the ui label Sep 14, 2022
@zofskeez zofskeez added this to the 1.12.0-rc1 milestone Sep 14, 2022
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming we confirmed that it is indeed meant to be authenticated as it appears our previous beliefs were that it was unauthenticated and for some reason that assumption was an error?

Also, I doesn't sound like this needs to be backported unless the bug request was coming from a user on a release version 2 or less back?

@zofskeez zofskeez closed this Sep 15, 2022
@zofskeez zofskeez reopened this Sep 15, 2022
@zofskeez
Copy link
Contributor Author

LGTM. I'm assuming we confirmed that it is indeed meant to be authenticated as it appears our previous beliefs were that it was unauthenticated and for some reason that assumption was an error?

Yes I checked with the backend folks and they pointed me to the PR I mentioned and suggested that we update the UI and docs accordingly.

Also, I doesn't sound like this needs to be backported unless the bug request was coming from a user on a release version 2 or less back?

I don't think it needs a backport since it's more of an improvement rather than a bug.

@zofskeez zofskeez merged commit 664e0c3 into main Sep 15, 2022
@zofskeez zofskeez deleted the ui/VAULT-8123 branch September 15, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants