Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds sslinline option to postgres conn string #26826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhoriuchi
Copy link

  • for database secrets type postgres, inspects the connection string for sslinline and generates a tlsconfig from the connection string.
  • standard operation of the driver expects sslcert, sslkey, and sslrootcert to be file paths
  • the workaround cleans the connection string of all ssl and uses the stdlib.RegisterConnConfig method to add a new connection with a custom tlsconfig. most of the code is forked/ported from the github.com/jackc/pgconn package because the functions are not exposed.

* for database secrets type postgres, inspects the connection string for sslinline and generates a tlsconfig from the connection string.
Copy link

hashicorp-cla-app bot commented May 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bhoriuchi, thanks for the contribution. We will need to review this more internally before we can decisively say we can accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants