Add support for go-sockaddr templated addresses in config. #9109
+92
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # command/server/config_test_helpers.go
|
Hey @ncabatoff Can you rebase this PR and resolve the conflicts? I'd like to use this in Vault as soon as we can get it merged and a new minor/patch release of Vault put out. I need to be able to use the very nice functionality of go-sockaddr in my configuration just like what Nomad and Consul support 🤣 cheers! 🙇♂️ |
# Conflicts: # command/server/config_test.go
briankassouf
approved these changes
Oct 12, 2021
Will do. Unrelated to docs, does the fact that the change is under internalshared require any extra action on my part? |
|
@ncabatoff Nothing to do in internalshared. We haven't yet moved over to the new listenerutil yet, but you may want to duplicate the logic there so we don't have a regression when we do migrate. |
ncabatoff
added a commit
to hashicorp/go-secure-stdlib
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6409.
I don't know what the repercussions of modifying internalshared are, will have to follow up.