Upgrade HASH Graph dependencies #1195

Alfred-Mountfield · 2022-10-12T17:24:24Z

🌟 What is the purpose of this PR?

We were starting to fall behind on dependency versions, there were a few major (or at least breaking) updates made to our dependencies. This PR upgrades all dependencies (or at least all the ones that were automatically selected by cargo upgrade --workspace).

This also means we are using a proper release of error-stack again rather than a direct git hash.

🔗 Related links

Asana task (internal)

🔍 What does this change?

Runs cargo upgrade and updates the versions for packages (look to diff for comprehensive list)
Stop depending on a git hash for utoipa and use their newest release
- Changes our uses of Component to ToSchema
- Changes our usages of handlers to paths in utoipa (they changed the attribute)
- Changes some of our own modifying code to accept the new API
Upgrades clap to version 4
- Removes DeriveDisplayOrder as apparently this is default now (Builder and clap_derive should be WYSIWYG clap-rs/clap#2808)
- Removes AppSettings because it does not exist anymore (and is unneeded because of above)
- Replaces arg_enum with value_enum (fix(derive): Remove deprecated arg_enum attribute clap-rs/clap#4127)

📜 Does this require a change to the docs?

The OpenAPI spec has been regenerated, I don't believe anything else needs changing

⚠️ Known issues

~~I've added a new dependency on indexmap but we can probably remove it. I've opened a comment to highlight it.~~

🐾 Next steps

Upgrade the engine and other Rust projects to use the new error-stack

🛡 What tests cover this?

All tests that interact with the graph, follow the READMEs, but CI should be good enough.

Alfred-Mountfield · 2022-10-13T09:20:08Z

packages/graph/hash_graph/lib/graph/src/api/rest/mod.rs

    for content in content.values_mut() {
        modify_schema_references(&mut content.schema);
    }
 }

-fn modify_schema_references(schema_component: &mut openapi::Component) {
+// TODO: can we avoid importing IndexMap here?


There doesn't seem to be a trait we can rely on? Maybe we can pass a mutable iterator in here instead of taking the map?

(I was hoping all Maps would inherit from some Map trait but it turns out there are good reasons for not doing so)

Removed it with IntoIterator

Alfred-Mountfield · 2022-10-13T09:23:28Z

packages/graph/hash_graph/bin/hash_graph/Cargo.toml

-axum = "0.5.11"
-clap = { version = "3.2.10", features = ["cargo", "derive", "env", "wrap_help"] }
-clap_complete = "3.2.3"
-# TODO: Change to `version = "0.2"` as soon as it's released


We still haven't swapped to 0.2 in the engine and such, didn't want to do it in this pr. cc @TimDiekmann

TimDiekmann

LGTM 🎉

Not a requested change, but we could use the opportunity to bump the tools as well:

hash/.github/scripts/rust/Makefile.toml

Lines 220 to 226 in d7c2bdf

    
           [tasks.install-cargo-hack] 
        
           private = true 
        
           install_crate = { crate_name = "cargo-hack", version = "0.5.15", binary = "cargo", test_arg = ["hack", "--version"] } 
        
           [tasks.install-cargo-nextest] 
        
           private = true 
        
           install_crate = { crate_name = "cargo-nextest", version = "0.9.28", binary = "cargo", test_arg = ["nextest", "--version"] }

hash/.github/workflows/rust.yml

Lines 81 to 82 in d7c2bdf

    
                     cargo quickinstall cargo-make --version 0.35.15 
        
                     cargo quickinstall cargo-hack --version 0.5.15

hash/.github/workflows/rust.yml

Lines 142 to 144 in d7c2bdf

    
                     cargo quickinstall cargo-make --version 0.35.15 
        
                     cargo quickinstall cargo-hack --version 0.5.15 
        
                     cargo quickinstall cargo-nextest --version 0.9.28

hash/.github/workflows/rust.yml

Line 208 in d7c2bdf

cargo quickinstall cargo-make --version 0.35.15

hash/.github/workflows/rust.yml

Lines 241 to 243 in d7c2bdf

    
                     cargo quickinstall cargo-make --version 0.35.15 
        
                     cargo quickinstall cargo-hack --version 0.5.15 
        
                     cargo quickinstall cargo-nextest --version 0.9.28

Alfred-Mountfield · 2022-10-13T12:31:31Z

@TimDiekmann

I'll avoid updating the tooling versions just because this is nicely constrained to the graph at the moment, and most of the tools are defined at a repo level. I agree we should probably do that as a follow up (perhaps when migrating the engine and such to use the release of error-stack

Alfred-Mountfield added 7 commits October 12, 2022 18:00

Upgrade dependencies

3e477db

arg_enum to value_enum

3412a00

Remove clap AppSettings

e1aaf5f

Replace Component with ToSchema

a68d375

Fix openapi Component

e7f7c70

Fix openapi derives

65b5b7c

Upgrade error-stack

1d81b64

github-actions bot added A-backend area/deps Relates to third-party dependencies (area) labels Oct 12, 2022

vercel bot deployed to Preview – hash October 12, 2022 17:28 View deployment

Alfred-Mountfield commented Oct 13, 2022

View reviewed changes

Fix api gen

aa415cb

Alfred-Mountfield commented Oct 13, 2022

View reviewed changes

vercel bot deployed to Preview – hash October 13, 2022 09:25 View deployment

Alfred-Mountfield requested a review from a team October 13, 2022 09:32

Alfred-Mountfield marked this pull request as ready for review October 13, 2022 09:32

Alfred-Mountfield and others added 2 commits October 13, 2022 10:38

Remove dependency on indexmap

5ad8b14

Merge branch 'main' into am/update-dependencies

dd312e2

vercel bot deployed to Preview – hash October 13, 2022 09:46 View deployment

Use impl instead of generic

7bce793

vercel bot deployed to Preview – hash October 13, 2022 09:52 View deployment

TimDiekmann approved these changes Oct 13, 2022

View reviewed changes

Alfred-Mountfield merged commit 97e2c28 into main Oct 13, 2022

Alfred-Mountfield deleted the am/update-dependencies branch October 13, 2022 12:30

nonparibus added type/eng > backend Owned by the @backend team and removed area: backend labels Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade HASH Graph dependencies #1195

Upgrade HASH Graph dependencies #1195

Alfred-Mountfield commented Oct 12, 2022 •

edited

Alfred-Mountfield Oct 13, 2022

Alfred-Mountfield Oct 13, 2022

Alfred-Mountfield Oct 13, 2022

Alfred-Mountfield Oct 13, 2022

TimDiekmann left a comment

Alfred-Mountfield commented Oct 13, 2022

	[tasks.install-cargo-hack]
	private = true
	install_crate = { crate_name = "cargo-hack", version = "0.5.15", binary = "cargo", test_arg = ["hack", "--version"] }

	[tasks.install-cargo-nextest]
	private = true
	install_crate = { crate_name = "cargo-nextest", version = "0.9.28", binary = "cargo", test_arg = ["nextest", "--version"] }

	cargo quickinstall cargo-make --version 0.35.15
	cargo quickinstall cargo-hack --version 0.5.15

	cargo quickinstall cargo-make --version 0.35.15
	cargo quickinstall cargo-hack --version 0.5.15
	cargo quickinstall cargo-nextest --version 0.9.28

Upgrade HASH Graph dependencies #1195

Upgrade HASH Graph dependencies #1195

Conversation

Alfred-Mountfield commented Oct 12, 2022 • edited

🌟 What is the purpose of this PR?

🔗 Related links

🔍 What does this change?

📜 Does this require a change to the docs?

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

Alfred-Mountfield Oct 13, 2022

Choose a reason for hiding this comment

Alfred-Mountfield Oct 13, 2022

Choose a reason for hiding this comment

Alfred-Mountfield Oct 13, 2022

Choose a reason for hiding this comment

Alfred-Mountfield Oct 13, 2022

Choose a reason for hiding this comment

TimDiekmann left a comment

Choose a reason for hiding this comment

Alfred-Mountfield commented Oct 13, 2022

Alfred-Mountfield commented Oct 12, 2022 •

edited