-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-2711, H-2712, H-2715: Add /goals
and /goals/new
pages
#4485
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4485 +/- ##
==========================================
- Coverage 21.44% 21.15% -0.30%
==========================================
Files 453 456 +3
Lines 15007 15215 +208
Branches 2221 2273 +52
==========================================
Hits 3218 3218
- Misses 11748 11956 +208
Partials 41 41 β View full report in Codecov by Sentry. |
/goals
and /goals/new
pages/goals
and /goals/new
pages
/goals
and /goals/new
pages/goals
and /goals/new
pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Ciaran, the changes look good to me and are working as expected π
4869b15
to
9c9cbf5
Compare
β¦ with errors at workflow level
d84b170
to
a688151
Compare
@benwerner01 I fixed the bug in the popup you identified in e5c5f16, as well as another one where the user was being overfetched, causing settings changes to be overwritten sometimes |
π What is the purpose of this PR?
Adds the following pages:
/goals
, which lists all active goal tasks (goals are research-driven flows)/goals/new
, which allows creating a new goal taskFor now, the goals task is a special flow definition. Later on the flow definition itself will be generated by AI.
Internal designs are here
Driveby:
Pre-Merge Checklist π
π’ Has this modified a publishable library?
This PR:
π Does this require a change to the docs?
The changes in this PR:
πΈοΈ Does this require a change to the Turbo Graph?
The changes in this PR:
turbo.json
's have been updated to reflect thisπ‘ What tests cover this?
β How to test this?
πΉ Demo
New pages
Kapture.2024-05-19.at.15.44.15.mp4
Progress log tooltips with model plan / explanation of actions
Kapture.2024-05-20.at.16.02.07.mp4