Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-2711, H-2712, H-2715: Add /goals and /goals/new pages #4485

Merged
merged 11 commits into from
May 23, 2024

Conversation

CiaranMn
Copy link
Member

@CiaranMn CiaranMn commented May 19, 2024

🌟 What is the purpose of this PR?

Adds the following pages:

  1. /goals, which lists all active goal tasks (goals are research-driven flows)
  2. /goals/new, which allows creating a new goal task

For now, the goals task is a special flow definition. Later on the flow definition itself will be generated by AI.

Internal designs are here

Driveby:

  • H-2712: expose model plan/explanation for actions as part of progress logs (see second demo)
  • H-2715: In the browser plugin history log, show where the plugin has responded to a flow's request for a web page content

Pre-Merge Checklist πŸš€

🚒 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

πŸ“œ Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

πŸ•ΈοΈ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph
  • affected the execution graph, and the turbo.json's have been updated to reflect this
  • I am unsure / need advice

⚠️ Known issues

  • H-2722: The goals should have distinguishing names based on the research prompt somehow

πŸ›‘ What tests cover this?

  • None yet

❓ How to test this?

  1. Check out the new pages

πŸ“Ή Demo

New pages

Kapture.2024-05-19.at.15.44.15.mp4

Progress log tooltips with model plan / explanation of actions

Kapture.2024-05-20.at.16.02.07.mp4

@CiaranMn CiaranMn requested a review from benwerner01 May 19, 2024 14:49
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 21.15%. Comparing base (7ef056a) to head (e5c5f16).

Files Patch % Lines
...sh-ai-worker-ts/src/workflows/run-flow-workflow.ts 0.00% 9 Missing ⚠️
...l/hash-backend-utils/flows/get-flow-run-details.ts 0.00% 5 Missing ⚠️
...vities/flow-activities/research-entities-action.ts 0.00% 3 Missing ⚠️
apps/hash-api/src/ai/infer-entities-websocket.ts 0.00% 2 Missing ⚠️
...w-activities/infer-entities-from-content-action.ts 0.00% 1 Missing ⚠️
...orphic-utils/src/flows/example-flow-definitions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4485      +/-   ##
==========================================
- Coverage   21.44%   21.15%   -0.30%     
==========================================
  Files         453      456       +3     
  Lines       15007    15215     +208     
  Branches     2221     2273      +52     
==========================================
  Hits         3218     3218              
- Misses      11748    11956     +208     
  Partials       41       41              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@CiaranMn CiaranMn changed the title H-2711: Add /goals and /goals/new pages H-2711, H-2715: Add /goals and /goals/new pages May 19, 2024
@CiaranMn CiaranMn changed the title H-2711, H-2715: Add /goals and /goals/new pages H-2711, H-2712, H-2715: Add /goals and /goals/new pages May 20, 2024
benwerner01
benwerner01 previously approved these changes May 22, 2024
Copy link
Member

@benwerner01 benwerner01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ciaran, the changes look good to me and are working as expected πŸ‘

Base automatically changed from cm/flow-runs-page to main May 22, 2024 17:38
@CiaranMn CiaranMn dismissed benwerner01’s stale review May 22, 2024 17:38

The base branch was changed.

@CiaranMn
Copy link
Member Author

@benwerner01 I fixed the bug in the popup you identified in e5c5f16, as well as another one where the user was being overfetched, causing settings changes to be overwritten sometimes

@CiaranMn CiaranMn requested a review from benwerner01 May 23, 2024 10:06
@CiaranMn CiaranMn enabled auto-merge May 23, 2024 10:13
@CiaranMn CiaranMn added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 30428bf May 23, 2024
65 checks passed
@CiaranMn CiaranMn deleted the cm/new-goals-page branch May 23, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

None yet

2 participants