Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce shared UI folder #454

Merged
merged 8 commits into from
Apr 1, 2022
Merged

Introduce shared UI folder #454

merged 8 commits into from
Apr 1, 2022

Conversation

teenoh
Copy link
Contributor

@teenoh teenoh commented Mar 31, 2022

🌟 What is the purpose of this PR?

This is a follow up to #453. It introduces the new shared/ui folder which includes primitive components that are used in the frontend codebase. It also introduces shared/icons for our icons.

⚠️ Known issues

🐾 Next steps

  • create shared/layout for page layout components

πŸ” What does this change?

  • Adds a new shared/ui folder which contains UI primitives and theme
  • Updates codebase to pull primitives/theme from shared/ui
  • Adds a shared/icons folder for our icons

πŸ“œ Does this require a change to the docs?

  • No

πŸ”— Related links

πŸ›‘ What tests cover this?

  • None

❓ How to test this?

  1. There are no visual changes, the app should still work without breaking

πŸ“Ή Demo


@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) frontend labels Mar 31, 2022
@semgrep-app
Copy link

semgrep-app bot commented Mar 31, 2022

Semgrep found 1 react-props-injection finding:

  • packages/hash/frontend/src/shared/ui/button.tsx: L89-107

Inject arbitrary props into the new element. It may introduce an XSS vulnerability.

βšͺ️ This finding does not block your pull request.
πŸ™ˆ From typescript.react.security.audit.react-props-injection.react-props-injection.

@teenoh teenoh requested a review from kachkaev March 31, 2022 23:41
@teenoh teenoh changed the title Shared UI folder Introduce shared UI folder Mar 31, 2022
kachkaev
kachkaev previously approved these changes Apr 1, 2022
Copy link
Contributor

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @teenoh! The diff makes sense!

@teenoh teenoh merged commit f68a298 into main Apr 1, 2022
@teenoh teenoh deleted the vu/shared-ui-folder branch April 1, 2022 11:46
@teenoh teenoh mentioned this pull request Apr 6, 2022
@vilkinsons vilkinsons added type/eng > frontend Owned by the @frontend team and removed area: frontend labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

None yet

3 participants