Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base image for smaller builds #382

Closed
wants to merge 1 commit into from

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Feb 5, 2024

Proposed Changes

Not sure what the correct way to describe the title change to reflect changing the base image to meet your guidelines so please advice.

I noticed that the final image has node baked in which it does not need and this change leverages your generic base image instead.

tasmoadmin                                 after                a6f89cf30ae5   27 seconds ago   83.4MB
tasmoadmin                                 before               baec78957941   8 minutes ago    208MB

Related Issues

(Github link to related issues or pull requests)

@inverse
Copy link
Contributor Author

inverse commented Feb 5, 2024

Closing due to explaination in #381

@inverse inverse closed this Feb 5, 2024
@inverse inverse deleted the change-base-image branch February 5, 2024 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant