Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBD Set default value of loading to true #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ichi404gh
Copy link

TBD

Initial value of isLoading is false and userInfo is null, what is obviously inconsistent. That values are passed to Consumer's children and can lead to wrong behavior, as described in #17, for example.

I suggest to set initial isLoading value to true, so components can rely on both isLoading and userInfo, especially right after rendering.

@stevenkissack
Copy link

We ran into this issue straight away also, is the repo stale and requiring personal forks? @karthikvt26 are you able to merge and cut a release of the two main feature PRs?

@karthikvt26
Copy link
Collaborator

Thanks @ichi404gh for the PR. Have been super busy with some work. Will definitely check it out in some time.

@stevokk Will definitely check it out and release them asap.

@stevenkissack
Copy link

@karthikvt26 we're starting a new project and pulling the local fix version over, can we get these merged or are you requiring some legwork on our end to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants