-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: worker semaphore slot resolver #477
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sr."workerId", | ||
COUNT(*) AS runningRuns | ||
FROM "StepRun" sr | ||
WHERE sr."status" IN ('RUNNING', 'ASSIGNED') AND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abelanger5 can you confirm if an ASSIGNED task takes a slot?
) | ||
FROM "Worker" w | ||
WHERE ws."workerId" = w."id" | ||
AND "slots" != COALESCE(w."maxRuns", 100) - COALESCE( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine for now, its not guaranteed to update on every interval but it will update to the correct value
Description
Adds an interval based query to ensure semaphore values are accurate.
Depends on #476
Type of change
What's Changed