Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve reassign and timeout behavior and visibility #484

Merged
merged 14 commits into from
May 14, 2024
Merged

feat: improve reassign and timeout behavior and visibility #484

merged 14 commits into from
May 14, 2024

Conversation

grutt
Copy link
Contributor

@grutt grutt commented May 10, 2024 •
edited

Description

Improves consistency for how we handle reassignments and retires.

Type of change

  • Documentation change (pure documentation change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

What's Changed

  • added step run events for reassignments and timeouts
  • runtime timeouts are treated as failures, meaning they are handled the same as an error and will exhibit the same retry behavior
  • reduced last heartbeat check from 60s to 30s to improve reassign performance
  • updated docs to reflect timeout behavior

@grutt grutt requested a review from abelanger5 May 10, 2024 18:35
@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 7:31pm

@abelanger5 abelanger5 merged commit b728616 into main May 14, 2024
19 checks passed
@abelanger5 abelanger5 deleted the feat--improve-reassign branch May 14, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelanger5 abelanger5 abelanger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grutt @abelanger5