Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

Properly reset css based on https://meyerweb.com/eric/tools/css/reset/ #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

khinshankhan
Copy link

Pull request checklist

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update
  • Refactoring
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Pretty sure the way js/ ts objects work, newer entries (top down) with the same key simply override older entries. This means the current

{
    content: "",
    // @ts-ignore
    content: "none",
}

is actually just

{
    content: "none",
}

which is technically wrong. Css does override as well but only if the style is supported. I'm not a stitches expert but I believe we can have support queries like so?

{
    "@supports (<test style here, unapplied>)": {
      // apply style here
    },
}

I also saw that the default behavior for tables was a bit off looking at https://meyerweb.com/eric/tools/css/reset/

Does this introduce a breaking change?

  • Yes
  • No

Other information

I don't believe the styling for pseudo blockquote elements is breaking, however the table's border collapse may be breaking(?)

If you'd like, I could open separate prs since the table styling may not be alright.

@khinshankhan
Copy link
Author

The initial bug that required the two content keys does seem to be resolved though https://bugs.webkit.org/show_bug.cgi?id=20032

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant