Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HxAutosuggest] [HxSearchBox] [HxInputTags] Keyboard navigation (up/down) stopped working #348

Closed
hakenr opened this issue Sep 2, 2022 · 4 comments · Fixed by #351
Closed

[HxAutosuggest] [HxSearchBox] [HxInputTags] Keyboard navigation (up/down) stopped working #348

hakenr opened this issue Sep 2, 2022 · 4 comments · Fixed by #351
Assignees
@Harvey1214
Labels
bug Something isn't working
Milestone
Priority 1 - High

Comments

@hakenr
Copy link
Member

hakenr commented Sep 2, 2022 •
edited

  1. Type something.
  2. Use ArrowDown to navigate to specific item.
    ...not working

cc @crdo @Harvey1214
@hakenr hakenr added the bug Something isn't working label Sep 2, 2022
@hakenr hakenr added this to the Priority 1 - High milestone Sep 2, 2022
@hakenr
Copy link
Member Author

hakenr commented Sep 2, 2022 •
edited

Same with HxSearchBox.

@Harvey1214
Copy link
Member

@hakenr, I agree with @crdo, this issue arose with the Bootstrap upgrade. Also, there haven't been any changes to the HxSearchBox since the structure change.

@hakenr
Copy link
Member Author

hakenr commented Sep 2, 2022 •
edited

This is our current issue:
https://github.com/twbs/bootstrap/blob/337068f8b1044004f4b9abfffbb433694ae87993/js/src/dropdown.js#L391-L405

Related:
PR: twbs/bootstrap#33479
Issue: twbs/bootstrap#33465

@hakenr hakenr changed the title [HxAutosuggest] Keyboard navigation stopped working [HxAutosuggest] [HxSearchBox] Keyboard navigation stopped working Sep 2, 2022
@Harvey1214 Harvey1214 self-assigned this Sep 2, 2022
Harvey1214 added a commit that referenced this issue Sep 2, 2022
@Harvey1214
[HxSearchBox] Keyboard navigation #348
c206025
@Harvey1214 Harvey1214 linked a pull request Sep 2, 2022 that will close this issue
[HxSearchBox] [HxAutoauggest] [HxInputTags] Keyboard navigation #348 #351
Merged
@crdo
Copy link
Member

crdo commented Sep 5, 2022

So it has been already discussed and closed as won't fix.

Harvey1214 added a commit that referenced this issue Sep 5, 2022
@Harvey1214
Move KeybaordNavigation to a dedicated region #348
7cdcf99
Harvey1214 added a commit that referenced this issue Sep 5, 2022
@Harvey1214
[HxSearchBox} Keyboard navigation adjustments + HightLightFirstSugges…
8f5179a 
…tion #348
Harvey1214 added a commit that referenced this issue Sep 5, 2022
@Harvey1214
[HxAutosuggest] Keyboard navigation #348
b30e64f
@hakenr hakenr changed the title [HxAutosuggest] [HxSearchBox] Keyboard navigation stopped working [HxAutosuggest] [HxSearchBox] [HxInputTags] Keyboard navigation (up/down) stopped working Sep 6, 2022
hakenr added a commit that referenced this issue Sep 7, 2022
@hakenr
Merge pull request #351 from havit/feature/HxSearchBoxKeyboardNavigation
ab0a342 
[HxSearchBox] [HxAutoauggest] [HxInputTags] Keyboard navigation #348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harvey1214 Harvey1214

Labels
bug Something isn't working
Projects
None yet
Milestone
Priority 1 - High
Development

Successfully merging a pull request may close this issue.

[HxSearchBox] [HxAutoauggest] [HxInputTags] Keyboard navigation #348 havit/Havit.Blazor
3 participants
@crdo @hakenr @Harvey1214