Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HxSearchBox] [HxAutoauggest] [HxInputTags] Keyboard navigation #348 #351

Merged
merged 17 commits into from Sep 7, 2022
Merged

[HxSearchBox] [HxAutoauggest] [HxInputTags] Keyboard navigation #348 #351

merged 17 commits into from Sep 7, 2022

Conversation

Harvey1214
Copy link
Member

@Harvey1214 Harvey1214 commented Sep 2, 2022 •
edited

WIP - works but implementation needs polish. Will complete it on Monday and once it's approved, will bring this functionality over to HxAutosuggest.

@Harvey1214 Harvey1214 self-assigned this Sep 2, 2022
@Harvey1214 Harvey1214 linked an issue Sep 2, 2022 that may be closed by this pull request
[HxAutosuggest] [HxSearchBox] [HxInputTags] Keyboard navigation (up/down) stopped working #348
Closed
@hakenr hakenr added the v3.0.0 label Sep 3, 2022
@hakenr hakenr added this to the v3.0.0 milestone Sep 3, 2022
hakenr
hakenr requested changes Sep 4, 2022
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the POC look acceptable as a temporary solution (just added a few comments to the implementation, try to finish it and replicate to the second component

Havit.Blazor.Components.Web.Bootstrap/Forms/SearchBox/HxSearchBox.razor.cs Outdated Show resolved Hide resolved
Havit.Blazor.Components.Web.Bootstrap/Forms/SearchBox/HxSearchBox.razor.cs Outdated Show resolved Hide resolved
Havit.Blazor.Components.Web.Bootstrap/Forms/SearchBox/HxSearchBox.razor.cs Show resolved Hide resolved
@hakenr hakenr changed the title [HxSearchBox] Keyboard navigation #348 [HxSearchBox] [HxAutoauggest] Keyboard navigation #348 Sep 6, 2022
@hakenr
Copy link
Member

hakenr commented Sep 6, 2022 •
edited by Harvey1214

TODOs

  • Replicate solution for HxInputTags (also derived from HxAutosuggest) @Harvey1214
  • Update doc (adjust the DocAlert with updated info on the issue) @hakenr
  • Remove HightlightFirstSuggestion parameters? @hakenr

@hakenr hakenr changed the title [HxSearchBox] [HxAutoauggest] Keyboard navigation #348 [HxSearchBox] [HxAutoauggest] [HxInputTags] Keyboard navigation #348 Sep 6, 2022
@hakenr hakenr linked an issue Sep 6, 2022 that may be closed by this pull request
[HxAutosuggest] Remove the HighlightFirstSuggestion parameter #361
Closed
@Harvey1214 Harvey1214 marked this pull request as ready for review September 7, 2022 16:29
@hakenr hakenr mentioned this pull request Sep 7, 2022
Closed
hakenr
hakenr approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hakenr hakenr merged commit ab0a342 into master Sep 7, 2022
@hakenr hakenr deleted the feature/HxSearchBoxKeyboardNavigation branch September 7, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakenr hakenr hakenr approved these changes

Assignees

@Harvey1214 Harvey1214

Labels
None yet
Projects
None yet
Milestone
v3.0.0
2 participants
@Harvey1214 @hakenr