HxDropdownItem - add Icon parameter, default and documentation #655
Conversation
There was a problem hiding this comment.
The HxDropdownItem is intended to be a "bare" Bootstrap component, and icons can be readily incorporated via the ChildContent. This is in contrast to HxContextMenuItem, which is a more comprehensive component that we define. Conversely, the HxButton does feature an Icon property. We could offer these enhancements to simplify the use of our component library.
However, I'm curious as to why you opted for HxDropdownItem to add the Icon property. Should this functionality also extend to HxDropdownItemNavLink and HxDropdownItemText? Perhaps even to HxDropdownHeader?
cc @crdo
| @@ -79,6 +80,9 @@ | |||
| --hx-context-menu-button-hover-background: var(--bs-secondary-bg); | |||
| --hx-context-menu-item-icon-margin: 0 .5rem 0 0; | |||
|
|
|||
| /* HxDropdown */ | |||
| --hx-dropdown-menu-item-icon: 0 .5rem 0 0; | |||
There was a problem hiding this comment.
This should be named --hx-dropdown-menu-item-icon-margin (see the HxContextMenuItem variable few lines above).
I noticed that the property 'Icon' is missing on HxDropdownItem. I added the property as it is implemented in HxContextMenuItem, including the CSS variable and documentation. Is there anything else I should do? :)