Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global quick search + "hidden" barcode scanner support #658

Open
wants to merge 83 commits into
base: main
Choose a base branch
from

Conversation

filp
Copy link

@filp filp commented Dec 8, 2023

What type of PR is this?

  • feature

What this PR does / why we need it:

This PR adds two major features, and some small tweaks and fixes around it:

  • Support for quick item search via cmd/ctrl+F (with fallback to system search by tapping cmd/ctrl+F again with quick search open)
image
  • Support for consumer USB barcode scanners to aid in item search, for GTIN-12 and GTIN-13 (UPC-A and EAN13)
    • This works by listening for global key events that look like a USB barcode scanner inputting a valid barcode, followed by the 'Enter' key; if this is detected, it generates a valid search query and forwards the user to the search page (these scanners act like a normal numeric keyboard). Effectively, this allows searching for an item by just scanning it, with no additional user action needed.
    • The actual barcode data at the moment is expected to be available under a custom 'Barcode' field, which is not a great long-term solution; a more appropriate solution might be a native barcode item field, or specific per-format barcode fields.

Additionally, it also includes the following:

  • Minor fix to the homebox logo on mobile, so that it's more accurately aligned vertically:
image
  • Changes BaseModal to not render modal contents unless modal is active, which prevents specific issues around focus handling (e.g trigger-focus on an input inside a modal)
  • Fixes trigger-focus on TextInput not working consistently
  • Introduces a temporary solution for custom field search not allowing arbitrary input

Release Notes

- Adds global quick search dialog via keyboard shortcut (cmd+F/ctrl+F)
- Adds initial support for searching for items via consumer USB barcode scanners

hay-kot and others added 30 commits July 22, 2023 19:57
* bump all deps

* run code-gen
…t#506)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t#508)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ay-kot#451)

* Fixed 3 places where API URLs were not constructed by function route(path, params).

* autofix

---------

Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
* formatting

* slimdown locations page

* update location/labels

* fix dependency issues

* fix type generator

* cleanup unused variables
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* add multiple new currencies

* add multiple new currencies

* remove duplicate yen
…port k… (hay-kot#526)

* add support for create + add more for all create modals and support keyboard bindings

* listen for esc to close modals
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…busting (hay-kot#527)

* rough implementation of WS based event system for server side notifications of mutation

* fix test construction

* fix deadlock on event bus

* disable linter error

* add item mutation events

* remove old event bus code

* refactor event system to use composables

* refresh items table when new item is added

* fix create form errors

* cleanup unnecessary calls

* fix importer erorrs + limit fn calls on import
* Added currencies XAG and XAU to currency.ts

I added XAG and XAU for myself and others who prefer to measure value with something of substance.

Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added.

https://www.iso.org/iso-4217-currency-codes.html
https://en.wikipedia.org/wiki/ISO_4217

Example:
https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD

API for exchange rates:
https://openexchangerates.org/

* Added field values xag and xau to group.go

* Update group.go
* fix https connection

* explicity dependency
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot and others added 28 commits November 15, 2023 17:58
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* expose timeout variables

* formatting
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* support parentID search

* fetch images for item children
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t#626)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

* fix error when item doesn't have photo attachment

* automatically detect image types and set primary photo if first

* remove charts.js from libs
…t#643)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t#629)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants