Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mode to inject templates after marker #139

Closed

Conversation

anthonychung14
Copy link

Closes #127

Adds a mode param that lets user inject code after the marker.

This has proven to be useful if we want to use a more understandable marker such as

at: "bob := map[string]Foo{"

rather than something more brittle/less understandable than

at: "&SomeRandomItemInList{}"

Also, in order to have tests pass on my machine, I had to change go.mod per instructions here golang/go#65568 (comment)

I can remove this, but I'm not super proficient at Go, so if there's another workaround, happy to remove this commit

@anthonychung14 anthonychung14 changed the title [Feat] Add mode to inject templates after marker feat: Add mode to inject templates after marker May 13, 2024
@anthonychung14
Copy link
Author

@hay-kot - wdyt? would like to use this. think it works given the test case.

@hay-kot
Copy link
Owner

hay-kot commented May 15, 2024

This looks good! I want to refactor some of those tests (not your code, my code) before I merge so give me a couple days and we'll get this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow inject AFTER
3 participants