-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid volatile writes from Atomics default values #22373
base: master
Are you sure you want to change the base?
Avoid volatile writes from Atomics default values #22373
Conversation
Can one of the admins verify this patch? |
11 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
run-lab-run |
Thanks for your contribution - I think this is a positive change. I'm concerned about the number and scope of changes that might cause conflicts with other open branches. Is it possible to focus these changes on any critical paths of the code to get the best improvement on a smaller scale? |
Most of these are inside tests. I can't tell what the "critical paths" are for you and what might conflict with other branches. You have a better overview of that. |
PR closed by Hazelcast automation as no activity (>6 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions |
This is still relevant. Please reopen this |
When benchmarking, on average they initialise ~10% faster when using implicit (over explicit) defaults. |
The job Click to expand the log file---------ERRORS----------- -------------------------- [ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.545 s <<< FAILURE! -- in com.hazelcast.internal.tpcengine.nio.NioAsyncServerSocketTest -------------------------- [ERROR] com.hazelcast.internal.tpcengine.nio.NioAsyncServerSocketTest.test_createCloseLoop_withSameReactor -- Time elapsed: 0.343 s <<< ERROR! -------------------------- [ERROR] Errors: -------------------------- [ERROR] NioAsyncServerSocketTest>AsyncServerSocketTest.test_createCloseLoop_withSameReactor:255 ? UncheckedIO Failed to bind to /127.0.0.1:5001 -------------------------- [ERROR] Tests run: 292, Failures: 0, Errors: 1, Skipped: 0 -------------------------- [ERROR] -------------------------- |
Hi,
this PR avoids volatile writes by removing the default parameters from
Atomic...
classes.Cheers,
Christoph
Checklist:
Team:
,Type:
,Source:
,Module:
) and Milestone setAdd to Release Notes
orNot Release Notes content
set@Nonnull/@Nullable
annotations@since
tags in Javadoc