Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for dumb terminal when using 'hz-cli sql' with non-terminal input/output #24855

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

ldziedziul
Copy link
Contributor

@ldziedziul ldziedziul commented Jun 20, 2023

Allow for a dumb terminal as a fallback if no system terminal detected in the hz-cli input or output.

Fixes: https://hazelcast.atlassian.net/browse/HZ-2610

Also see:

Testing:

Before:

$ docker exec -it hz-test sh
/opt/hazelcast $ echo exit\n | hz-cli sql
10:45:18.310 [ WARN] [o.jline] Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
Connected to Hazelcast 5.3.0 at [172.17.0.2]:5701 (+0 more)
Type 'help' for instructions
sql> Exiting from SQL console

After: no jline warning

$ docker exec -it hz-test sh
/opt/hazelcast $ echo exit\n | hz-cli sql
Connected to Hazelcast 5.4.0 at [172.17.0.3]:5701 (+0 more)
Type 'help' for instructions
sql> Exiting from SQL console

Breaking changes (list specific methods/types/messages):

  • API
  • client protocol format
  • serialized form
  • snapshot format

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@ldziedziul ldziedziul enabled auto-merge (squash) June 20, 2023 11:11
@ldziedziul ldziedziul merged commit ae05420 into hazelcast:master Jun 20, 2023
8 checks passed
@ldziedziul ldziedziul deleted the allow-for-dumb-terminal branch June 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants