-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZGC bean names to support GC stats #26329
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Internal PR hazelcast/hazelcast-mono#1855 |
3dd493b
to
66a2cdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change is ok for me. I wonder where we can see the complete list of bean names related to ZGC. I researched and found this other project that added those metrics to their project
Also see https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/gc/z/TestGarbageCollectorMXBean.java, maybe source code of jdk is good enough as well |
Import of #26329 **Original PR description:** The ZGC Garbage collector is not recognized since the "ZGC" name does not match the actual name/names. In the metrics it will be named as "unknown". This fix will match the actual ZGC names. Imported changes: - 66a2cdf Add proper ZGC support and renaming of internal set Closes #26329 --------- Co-authored-by: Robert Höglund <robban.hoglund@gmail.com> Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com> GitOrigin-RevId: db7d086b7c10b0ef130533dd51680673c9397b5a
The ZGC Garbage collector is not recognized since the "ZGC" name does not match the actual name/names. In the metrics it will be named as "unknown". This fix will match the actual ZGC names.
Fixes: N/A
Backport of: N/A
Breaking changes (list specific methods/types/messages):
I renamed these internal sets:
public static final Set YOUNG_GC; -> MINOR_GC
public static final Set OLD_GC; -> MAJOR_GC
Checklist:
Team:
,Type:
,Source:
,Module:
) and Milestone setAdd to Release Notes
label if changes should be mentioned in release notes orNot Release Notes content
if changes are not relevant for release notes@Nonnull/@Nullable
annotations@since
tags in Javadoc