Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password validation on signup #5224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benmai22
Copy link

@benmai22 benmai22 commented Apr 6, 2024

Added validation rules to the password field in the form component. The new validation checks include ensuring the password is at least 8 characters long, contains at least one number, one lowercase letter, and one uppercase letter. Updated the status object to include descriptive messages for the new validation rules.

Closes #4638

Screenshot 2024-04-06 at 7 38 10 PM

Huly®: UBERF-6392

Signed-off-by: benmai22 <benjaminmai017@gmail.com>
"PasswordLength": "La contraseña debe tener al menos 8 caracteres",
"PasswordNumber": "La contraseña debe contener al menos un número",
"PasswordLowercase": "La contraseña debe contener al menos una letra minúscula",
"PasswordUppercase": "La contraseña debe contener al menos una letra mayúscula"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these translations done using google translate ? @benmai22

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, what happened with approving this?

@benmai22
Copy link
Author

Are there any updates at this time?

@aonnikov
Copy link
Member

To me the changes look good, but I'm concerned about enabling this by default. Can we make this configurable?
@haiodo what do you think?

@benmai22
Copy link
Author

benmai22 commented May 10, 2024

I'd love for you to consider moving me on with this project as stated in your assessment. If everything is good, let's discuss rates of services provided and all that. My email is benjaminmai017@gmail.com @aonnikov

@benmai22
Copy link
Author

benmai22 commented May 13, 2024

Just following up, why is the approval process taking so long? @haiodo @aonnikov

@aonnikov
Copy link
Member

Just following up, why is the approval process taking so long? @haiodo @aonnikov

There is no approval because I don't to force users to use these password validation rules. I propose to make this configurable:

  • each rule can be enabled or disabled
  • if it is needed, the rule can be configurable (like min password length)

In this case users will be able to set up own password security policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't exist field validator for passwords in SignUp component of Platform
3 participants