-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password validation on signup #5224
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: benmai22 <benjaminmai017@gmail.com>
"PasswordLength": "La contraseña debe tener al menos 8 caracteres", | ||
"PasswordNumber": "La contraseña debe contener al menos un número", | ||
"PasswordLowercase": "La contraseña debe contener al menos una letra minúscula", | ||
"PasswordUppercase": "La contraseña debe contener al menos una letra mayúscula" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these translations done using google translate ? @benmai22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, what happened with approving this?
Are there any updates at this time? |
To me the changes look good, but I'm concerned about enabling this by default. Can we make this configurable? |
I'd love for you to consider moving me on with this project as stated in your assessment. If everything is good, let's discuss rates of services provided and all that. My email is benjaminmai017@gmail.com @aonnikov |
There is no approval because I don't to force users to use these password validation rules. I propose to make this configurable:
In this case users will be able to set up own password security policy. |
Added validation rules to the password field in the form component. The new validation checks include ensuring the password is at least 8 characters long, contains at least one number, one lowercase letter, and one uppercase letter. Updated the status object to include descriptive messages for the new validation rules.
Closes #4638
Huly®: UBERF-6392