Fix alignment of AssigneeBox button
#5228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Could you sign-off your commits to pass DCO check? |
Signed-off-by: Tannor Breitigam <70126993+breizeway@users.noreply.github.com>
breizeway
force-pushed
the
fix/project-assignee-box
branch
from
62d9379
to
50e1e46
Compare
Ah, of course. It should be ok now. |
|
It looks like there are formatting issues. Please resolve them when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I got the Huly platform up and running locally, I quickly noticed an alignment bug on the
AssigneeBoxcomponent on the "All Projects" in the "Tracker" section.After doing a little digging, it looks like this bug was introduced in PR #5013 with the addition of the
h-fullclass. This bug goes away if I remove that class, but--assuming that new class is necessary--it can be fixed in this instance by addingflex items-center. The size of the button was also inconsistent compared to others in the table, so I bumped it up tolarge.Huly®: UBERF-6396