Function Fix #5349
Closed
Function Fix #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: natalieday <natalieannday@gmail.com>
Signed-off-by: natalieday <natalieannday@gmail.com>
praveen-erramilli
approved these changes
Apr 14, 2024
aonnikov
approved these changes
Apr 25, 2024
aonnikov
reviewed
Apr 25, 2024
| @@ -73,8 +73,11 @@ export function checkAdaptiveMatching (size: WidthType | null, limit: WidthType) | |||
| return size !== null ? range.has(size) : false | |||
| } | |||
|
|
|||
| // TODO: Fix naming, since it doesn't floor (floorFractionDigits(2.5) === 3.0) | |||
| export function floorFractionDigits (n: number | string, amount: number): number { | |||
| // Renamed the function from floorFractionDigits to roundToFixedDecimal | |||
There was a problem hiding this comment.
Please remove this annotation from the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming function from floorFractionDigits to roundToFixedDecimal
Description:
This pull request addresses an issue with the function name floorFractionDigits, which was misleading as it implied flooring the number, whereas the function actually rounds to the nearest decimal value. To provide clarity and context for future developers working on this codebase, the function has been renamed to roundToFixedDecimal.
This change ensures that the function name accurately reflects its behavior, making the codebase more understandable and maintainable. All occurrences of the function name have been updated across the codebase to maintain consistency.
Resolved Issue: TODO: Fix naming, since it doesn't floor (floorFractionDigits(2.5) === 3.0)
Huly®: UBERF-6546